Skip to content

Commit

Permalink
[ADP-3414] Optimize benchmark history tracking (#4755)
Browse files Browse the repository at this point in the history
This  PR refactors and improve buildkite lib.

- Introduces a LimitsLock object to avoid `429` when the 200 API calls
per minute are surpassed.
- Factor out code from the benchmark-history exe into the buildkite lib

I also compute the benchmark history incrementally, by adding new data
points to the last checkpoint

- Exposes the csv database of benchmarks for further reuse
- Catch that csv while collecting new benchmark results, stopping the
collection there and simply amending it
  • Loading branch information
paolino authored Aug 30, 2024
2 parents 33bb717 + f376a11 commit c6aefbe
Show file tree
Hide file tree
Showing 12 changed files with 581 additions and 195 deletions.
1 change: 1 addition & 0 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ steps:
- trigger-benchmarks
artifact_paths:
- ./benchmark-history*.tgz
- ./benchmark-history.csv
command: |
./scripts/buildkite/main/benchmark-history.sh
agents:
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,6 @@ test/e2e/.direnv/flake-profile*
node_modules
package-lock.json
package.json

# buildkite artifacts testing
artifacts
3 changes: 3 additions & 0 deletions lib/benchmarks/cardano-wallet-benchmarks.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ library
hs-source-dirs: src
build-depends:
, aeson
, attoparsec
, base
, bytestring
, cardano-wallet
Expand Down Expand Up @@ -83,6 +84,7 @@ library
, time
, unliftio
, unliftio-core
, unordered-containers
, vector
, wai-middleware-logging
, with-utf8
Expand Down Expand Up @@ -275,6 +277,7 @@ executable benchmark-history
, cardano-wallet-buildkite
, cassava
, containers
, contra-tracer
, directory
, filepath
, exceptions
Expand Down
Loading

0 comments on commit c6aefbe

Please sign in to comment.