Feature/transaction info row #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jest@mock css modules - enzyme@add
|
Deploy request for cardano-explorer-mainnet pending review. Review with commit 64f1197 https://app.netlify.com/sites/cardano-explorer-mainnet/deploys |
|
Deploy request for cardano-explorer-testnet pending review. Review with commit 64f1197 https://app.netlify.com/sites/cardano-explorer-testnet/deploys |
DominikGuzei
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
Thanks for your contribution @gshohat!
The code looks good (haven't tested it visually though) 👍
Could you refactor your test to use https://testing-library.com/docs/react-testing-library/intro/ instead? It has a few advantages like de-coupling your DOM based testing from implementation details like css selectors and markup and in general seems to be the way forward with react testing 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encapsulate transaction info rows