Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved-premerge-summaries #1684

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Improved-premerge-summaries #1684

merged 2 commits into from
Sep 3, 2023

Conversation

TrevorBenson
Copy link
Collaborator

@TrevorBenson TrevorBenson commented Sep 3, 2023 •
edited
Loading

Description

  • Summary output as table format.
  • Adds the Guild Deploy and Cabal Build image ID's to Summary.
  • Includes the CARDANO_NODE_VERSION and GHC_VERSION in summary output.

Where should the reviewer start?

Motivation and context

  1. Easier to review the summary information presented.
  2. Quick access to which which image ID was generated.
  3. Quick access to which GHC was used to compile cardano binaries.
  4. Quick access to which cardano-node was compiled.

Which issue it fixes?

None.

How has this been tested?

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 September 3, 2023 21:26
@TrevorBenson TrevorBenson self-assigned this Sep 3, 2023
@TrevorBenson TrevorBenson force-pushed the improved-premerge-summaries branch from 29e8777 to 72a9825 Compare September 3, 2023 21:42
@rdlrt rdlrt merged commit 29344bf into alpha Sep 3, 2023
1 check failed
@rdlrt rdlrt deleted the improved-premerge-summaries branch September 3, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

@Scitz0 Scitz0 Awaiting requested review from Scitz0

Assignees

@TrevorBenson TrevorBenson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBenson @rdlrt