Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch as input for premerge workflow #1683

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

TrevorBenson
Copy link
Collaborator

Description

Adding the branch as a workflow input, and then setting it via input when defined allows pre-merge testing without opening a pull request.

Where should the reviewer start?

Original Workflow w/o Branch

  1. Choose Pre-merge workflow under actions
  2. Leave the alpha or main as the branch in theUse workflow from dropdown.
  3. Click Run workflow
  4. Observe BRANCH is missing and workflow eventially fails.

Updated Workflow w/ Branch

  1. Choose Pre-merge workflow under actions
  2. Select the branch-as-workflow-input as the branch in theUse workflow from dropdown.
  3. Click Run workflow
  4. Observe BRANCH is populated and the workflow runs as expected.

Motivation and context

  • Remove the need for opening a PR to test pre-merge workflows.
  • Reduce noise to collaborators emails who are monitoring the repository for Pull Requests.
  • Simplified Fork testing, commits to guild-deploy.sh or cabal-build-all.sh are no longer required to test a premerge workflow.

Which issue it fixes?

None, just feature/improvement.

How has this been tested?

With a mix of other enhancements (cherry-picked into separate PR's to submit) it was tested on this forked repo workflow

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 September 3, 2023 21:27
@TrevorBenson TrevorBenson self-assigned this Sep 3, 2023
@rdlrt rdlrt merged commit 7caa740 into alpha Sep 3, 2023
1 check passed
@rdlrt rdlrt deleted the branch-as-workflow-input branch September 3, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants