Matrix strategy based pre-merge testing. #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBenson
force-pushed
the
matrix-based-premerge-tests
branch
from
b0b777b to
b71eaa3
Compare
rdlrt
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use strategy matrix for pre-merge tests. Creates a
distrokey in the strategy matrix and then any item within this list is used to call the specific distro's build for guild-deploy.sh and cabal-build-all.sh testing.Where should the reviewer start?
Compare to an existing pre-merge. Adds a few lines to setup the matrix, and then abstracts the distribution name from later commands and uses
${{ matrix.distribution }}in its place.Motivation and context
distro: [ubuntu, rockylinux, debian]todistro: [ubuntu, rockylinux]disables the diabian pre-merge tests.Which issue it fixes?
No issue.
How has this been tested?
Testing within forked PR:
Notes
Since the current premerge debian is manually disabled, this PR has removed debian from the matrix distro list.