Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Added possible Byte-Array serialization #25

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Sep 10, 2024

No description provided.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (f8b5760) to head (c3056ca).

Files with missing lines Patch % Lines
.../io/carbynestack/httpclient/CsResponseHandler.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     88.05%   87.80%   -0.26%     
- Complexity       67       69       +2     
============================================
  Files             8        8              
  Lines           201      205       +4     
  Branches         16       19       +3     
============================================
+ Hits            177      180       +3     
  Misses           20       20              
- Partials          4        5       +1     
Files with missing lines Coverage Δ
.../io/carbynestack/httpclient/CsResponseHandler.java 96.00% <80.00%> (-4.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b5760...c3056ca. Read the comment docs.

Copy link
Member Author

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the individual comments and add yourself to the NOTICE.md file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Copyright

@@ -48,6 +50,16 @@ private static HttpResponse getHttpResponseForObject(int httpStatus, Object obj)
return response;
}

private static HttpResponse getHttpResponseForByteArr(int httpStatus, byte[] bytes) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why abbreviate "array"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants