-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Added possible Byte-Array serialization #25
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alwin Zomotor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
============================================
- Coverage 88.05% 87.80% -0.26%
- Complexity 67 69 +2
============================================
Files 8 8
Lines 201 205 +4
Branches 16 19 +3
============================================
+ Hits 177 180 +3
Misses 20 20
- Partials 4 5 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the individual comments and add yourself to the NOTICE.md
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update Copyright
@@ -48,6 +50,16 @@ private static HttpResponse getHttpResponseForObject(int httpStatus, Object obj) | |||
return response; | |||
} | |||
|
|||
private static HttpResponse getHttpResponseForByteArr(int httpStatus, byte[] bytes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why abbreviate "array"?
No description provided.