chore(service): address PR findings

Signed-off-by: Sebastian Becker <[email protected]>
carbynestack · Dec 17, 2024 · 70a3f67 · 70a3f67
1 parent 1604c39
commit 70a3f67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/ephemeral/io/feeder.go b/pkg/ephemeral/io/feeder.go
@@ -20,7 +20,7 @@ import (
 type Feeder interface {
 	// LoadFromSecretStoreAndFeed loads input parameters from Amphora.
 	LoadFromSecretStoreAndFeed(act *Activation, feedPort string, ctx *CtxConfig) ([]byte, error)
-	// LoadFromRequestAndFeed oads input parameteters from the request body.
+	// LoadFromRequestAndFeed loads input parameters from the request body.
 	//
 	// Deprecated: providing secrets in the request body is not recommended and will be removed in the future.
 	LoadFromRequestAndFeed(act *Activation, feedPort string, ctx *CtxConfig) ([]byte, error)
@@ -62,7 +62,7 @@ func (f *AmphoraFeeder) LoadFromSecretStoreAndFeed(act *Activation, feedPort str
 		if err != nil {
 			return nil, err
 		}
-		policy := "_DEFAULT_POLICY_"
+		policy := DefaultPolicy
 		owner, _ := findValueForKeyInTags(osh.Tags, "owner")
 		policy, _ = findValueForKeyInTags(osh.Tags, "accessPolicy")
 		inputs = append(inputs, ActivationInput{

diff --git a/pkg/types/consts.go b/pkg/types/consts.go
@@ -1,4 +1,4 @@
-// Copyright (c) 2021-2023 - for information on the respective copyright owner
+// Copyright (c) 2021-2024 - for information on the respective copyright owner
 // see the NOTICE file and/or the repository https://github.com/carbynestack/ephemeral.
 //
 // SPDX-License-Identifier: Apache-2.0
@@ -52,4 +52,6 @@ const (
 	EventScope              = "EventScope"
 	EventScopeAll           = "EventScopeAll"
 	EventScopeSelf          = "EventScropeSelf"
+
+	DefaultPolicy = "carbynestack.def"
 )