Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sources from cli-ng to common #2

Merged
merged 31 commits into from
Nov 12, 2021
Merged

Move sources from cli-ng to common #2

merged 31 commits into from
Nov 12, 2021

Conversation

grevend-bosch
Copy link
Contributor

Signed-off-by: David Greven [email protected]

@grevend-bosch grevend-bosch added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 8, 2021
@grevend-bosch grevend-bosch self-assigned this Nov 8, 2021
@grevend-bosch grevend-bosch linked an issue Nov 8, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@4224fd4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   92.14%           
  Complexity        ?       61           
=========================================
  Files             ?        7           
  Lines             ?      140           
  Branches          ?        6           
=========================================
  Hits              ?      129           
  Misses            ?        7           
  Partials          ?        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4224fd4...35854c7. Read the comment docs.

@grevend-bosch
Copy link
Contributor Author

- repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
rev: v2.0.0
hooks:
- id: pretty-format-java
args: [--autofix]

Needs to be removed because of JDK 17 (see carbynestack/cli-ng#18).

@grevend-bosch
Copy link
Contributor Author

grevend-bosch commented Nov 8, 2021

@sbckr @strieflin Test coverage can be ignored in this case, as the values ​​cannot be accurately calculated due to the division of classes between common-testing and common-types.

Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: David Greven <[email protected]>
@grevend-bosch grevend-bosch requested review from sbckr and removed request for strieflin November 12, 2021 07:11
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Codacy findings on NOTICE.md ignored as formatting matches our defaults.

@sbckr sbckr merged commit 53aaa0e into master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move existing cli-ng code to cs-common
2 participants