Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidepanel): implement decorator prop #6511

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

Closes #6454

What did you change?

implemented a new prop decorator and deprecated aiLabel

How did you test and verify your work?

yarn test
storybook

@makafsal makafsal requested a review from a team as a code owner November 27, 2024 05:50
@makafsal makafsal requested review from AlexanderMelox and anamikaanu96 and removed request for a team November 27, 2024 05:50
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 754fc10
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6747f226b61a4d00083cd723
😎 Deploy Preview https://deploy-preview-6511--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 754fc10
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6747f226bd5b640008e0ab94
😎 Deploy Preview https://deploy-preview-6511--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (9f31fc3) to head (754fc10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6511   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files         394      394           
  Lines       12877    12878    +1     
  Branches     4258     4258           
=======================================
+ Hits        10283    10284    +1     
  Misses       2594     2594           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename aiLabel prop to decorator in SidePanel
1 participant