fix(FullPageError): accessibility violations #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamikaanu96
requested review from
makafsal and
devadula-nandan
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6503 +/- ##
==========================================
- Coverage 79.86% 79.83% -0.04%
==========================================
Files 394 394
Lines 12877 12877
Branches 4258 4258
==========================================
- Hits 10284 10280 -4
- Misses 2593 2597 +4
|
2 tasks
devadula-nandan
requested changes
Nov 26, 2024
packages/ibm-products/src/components/FullPageError/FullPageError.tsx
Outdated
Show resolved
Hide resolved
makafsal
approved these changes
Nov 28, 2024
devadula-nandan
approved these changes
Nov 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 29, 2024
3f45528
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6230 #6232 #6233
Fixed the accessibility voilations
What did you change? packages/ibm-products/src/components/FullPageError/FullPageError.tsx
packages/ibm-products/src/components/FullPageError/assets/Error403SVG.js
packages/ibm-products/src/components/FullPageError/assets/Error404SVG.js
packages/ibm-products/src/components/FullPageError/assets/ErrorGenericSVG.js
packages/ibm-products/src/components/FullPageError/preview-components/UiShell.js
How did you test and verify your work? jaws