Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed from lodash to lodash-es #18162

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 26, 2024

Closes #17731

We are moving from lodash to lodash-es. That will solve security issues we were having in lodash and also it will lead to a smaller final bundle.

Here it is a Stackblitz with the code changes examples to show that the works.

Changelog

New

  • Added lodash-es dependency

Removed

  • Removed lodash dependencies

Testing / Reviewing

  • Build should work
  • CI should pass

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 029bd94
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67478180921c3c0008e05d05
😎 Deploy Preview https://deploy-preview-18162--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 029bd94
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6747818089db2c0008d4514f
😎 Deploy Preview https://deploy-preview-18162--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 029bd94
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674781801ec1980008496092
😎 Deploy Preview https://deploy-preview-18162--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Drop per-method lodash dependencies
1 participant