chore: add decorator in dataTable #18114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/styles/scss/components/data-table/sort/_data-table-sort.scss
Outdated
Show resolved
Hide resolved
Comment on lines
20
to
24
| /** | ||
| * @deprecated please use decorator instead. | ||
| * Provide a `Slug` component to be rendered inside the `TableSlugRow` component | ||
| */ | ||
| slug?: ReactNode; |
There was a problem hiding this comment.
do we need the deprecated slug if we are introducing a new component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18005
Add decorator in dataTable component
Changelog
Added a new component
TableDecoratorRowAdded a new deprecated warning function for components
Changed
slugas deprecated prop in all dataTable componentsTableSlugRowcomponent as deprecatedai-lableanddecoratorboth.Testing / Reviewing