Button guidance PR #4409
Button guidance PR #4409
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
I need to finish reviewing but don't want to lose my comments so far. Update: I'm done reviewing. Its looking good though! Most of my comments are little things or on sections that were probably out of scope for your work but wanted to leave comments anyways.
src/pages/components/button/images/button_usage_ub_interaction.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Ok, finished, awesome work @alina-jacob! Just smalls things. The style tab looked perfect, no notes there.
There was a problem hiding this comment.
Ok it looks good! I just happened to notice this one last thing on the final read through. There are three different "Note" styles happening. Plain text, italic and inline notification. We should at least streamline the plain text and italic ones. My recommendation would be to use the italic.
alina-jacob
added
status: one more review 👀
and removed
status: ready for review 👀
labels
|
There is a border around this image which needs to be removed. Other than that, I am going to approve because this looks awesome. Great job, @alina-jacob ! ⭐️ |
alina-jacob
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
|
It says that the deploy failed, but here it is the preview link: https://carbondesignsystem-git-fork-alina-j-e1227a-carbon-design-system.vercel.app/ |
Closes:
#4397: Belongs to button component guidance umbrella
#4176: Belongs to danger icon-only button guidance umbrella
Important links:
Figma file
Context