Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mix completer #2607

Merged
merged 2 commits into from
Nov 26, 2024
Merged

added mix completer #2607

merged 2 commits into from
Nov 26, 2024

Conversation

cfbender
Copy link
Contributor

Hi there! Saw there was no completer for mix, so I figured I'd take a stab at it. This is my first time writing go so feel free to give any feedback.

There are maybe some other things I could add like listing the deps for input into things like mix deps.update, but I wasn't totally sure how to so figured I could leave it to someone in the future (since to me those aren't high use commands).

@rsteube
Copy link
Member

rsteube commented Nov 26, 2024

related #2608

also support user specs for tasks with `mix.<task>.yaml`
@rsteube rsteube merged commit 4e4bc7e into carapace-sh:master Nov 26, 2024
3 checks passed
@rsteube
Copy link
Member

rsteube commented Nov 26, 2024

Think we should add the built-in tasks as subcommands - see #2608 .

Added some stuff.
FYI: wrapping it in an ActionCallback is fine (better safe than sorry), but in this particular case it isn't needed.
ActionExecCommand does it implicitly and we don't do anything with it that would warrant wrapping it additionally.

@cfbender
Copy link
Contributor Author

awesome, thanks @rsteube! appreciate the help there. I may take a look at that issue to add those and see what I can do some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants