Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change polyfill #1278

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Change polyfill #1278

merged 1 commit into from
Oct 6, 2024

Conversation

captbaritone
Copy link
Owner

@captbaritone captbaritone commented Oct 6, 2024

There's some strange interaction between the setImmediate polyfill import in jszip and the way rollup-plugin-polyfill-node handles polyfills https://github.com/FredKSchott/rollup-plugin-polyfill-node/blob/main/src/index.ts#L64 that leads jszip's polyfill to get removed and rollup-plugin-polyfill-node's to not get included.

Trying to see if this older implementation works.

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for vigorous-lalande-5190c2 ready!

Name Link
🔨 Latest commit 2966ed3
🔍 Latest deploy log https://app.netlify.com/sites/vigorous-lalande-5190c2/deploys/6702cdc9436c900008ec04bb
😎 Deploy Preview https://deploy-preview-1278--vigorous-lalande-5190c2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 6, 2024

Size Change: +1.67 kB (+0.35%)

Total Size: 471 kB

Filename Size Change
./packages/webamp/built/webamp.bundle.min.js 292 kB +1.67 kB (+0.57%)
ℹ️ View Unchanged
Filename Size
./packages/webamp/built/webamp.lazy-bundle.min.js 179 kB

compressed-size-action

@captbaritone captbaritone merged commit 67e6cdf into master Oct 6, 2024
7 checks passed
captbaritone added a commit that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant