Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work to deprecate pickle flag #459

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Work to deprecate pickle flag #459

merged 3 commits into from
Jun 30, 2024

Conversation

stephenpardy
Copy link
Contributor

Starts work toward: #458

What

  • Moves the pickle loading functionality into the deserialize string. This is the first step of adding functionality for other model types.
  • Followups include: xgboost support, ONNX support.

How to Test

  • Run new and existing unit tests.

@stephenpardy stephenpardy requested review from a team as code owners June 28, 2024 19:58
ryanSoley
ryanSoley reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@ryanSoley ryanSoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! left some comments around the error handling

rubicon_ml/client/artifact.py Outdated Show resolved Hide resolved
rubicon_ml/client/artifact.py Outdated Show resolved Hide resolved
@stephenpardy stephenpardy requested a review from ryanSoley June 29, 2024 00:05
@stephenpardy stephenpardy merged commit 8c4c88b into main Jun 30, 2024
7 checks passed
@stephenpardy stephenpardy deleted the pickling branch June 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanSoley ryanSoley ryanSoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenpardy @ryanSoley