Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch exception, column output change #358

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rhaffar
Copy link
Contributor

@rhaffar rhaffar commented Nov 27, 2024

  • Snowflake throws an error for diff calcs on non-numeric columns in the form of a ProgrammingError, but it seems on rare occasion it will throw the exact same error with the same message as a DatabaseError. Unsure as to what's happening in the Snowflake backend to cause this, but we should catch both to be safe. SnowparkClientException catch has been removed - it was intended to catch general Snowpark exceptions, but these diff failures come from Snowflake itself failing to calculate the diff, not from Snowpark.
  • Adding column name display

Will post passing tests as soon as tests are done running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant