Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output: better explanation of what triggered asset precompilation + added option to do forced precompile #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve output: better explanation of what triggered asset precompilation + added option to do forced precompile #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad5a911
Improve output better explaining what triggered asset precompilation
NielsKSchjoedt Oct 29, 2019
36b2b99
Add option to do forced_precompile
NielsKSchjoedt Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions lib/capistrano/tasks/faster_assets.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

# set the locations that we will look for changed assets to determine whether to precompile
set :assets_dependencies, %w(app/assets lib/assets vendor/assets Gemfile.lock config/routes.rb)
set :force_precompile, false

# clear the previous precompile task
Rake::Task["deploy:assets:precompile"].clear_actions
Expand All @@ -17,16 +18,18 @@ namespace :deploy do
within release_path do
with rails_env: fetch(:rails_env) do
begin
raise PrecompileRequired.new("A forced precompile was triggered") if fetch(:force_precompile)

# find the most recent release
latest_release = capture(:ls, '-xr', releases_path).split[1]

# precompile if this is the first deploy
raise PrecompileRequired unless latest_release
raise PrecompileRequired.new('Fresh deployment detected (no previous releases present)') unless latest_release

latest_release_path = releases_path.join(latest_release)

# precompile if the previous deploy failed to finish precompiling
execute(:ls, latest_release_path.join('assets_manifest_backup')) rescue raise(PrecompileRequired)
execute(:ls, latest_release_path.join('assets_manifest_backup')) rescue raise PrecompileRequired.new('The previous deployment does not have any assets_manifest_backup this indicates precompile was not successful')

fetch(:assets_dependencies).each do |dep|
release = release_path.join(dep)
Expand All @@ -36,11 +39,9 @@ namespace :deploy do
next if [release, latest].map{|d| test "[ -e #{d} ]"}.uniq == [false]

# execute raises if there is a diff
execute(:diff, '-Nqr', release, latest) rescue raise(PrecompileRequired)
execute(:diff, '-Nqr', release, latest) rescue raise PrecompileRequired.new("Found a difference between the current and the new version of: #{dep}")
end

info("Skipping asset precompile, no asset diff found")

# copy over all of the assets from the last release
release_asset_path = release_path.join('public', fetch(:assets_prefix))
# skip if assets directory is symlink
Expand All @@ -60,11 +61,13 @@ namespace :deploy do
# Support sprockets 3
execute(:ls, release_asset_path.join('.sprockets-manifest*'))
rescue
raise(PrecompileRequired)
raise PrecompileRequired.new("No sprockets-manifest found")
end
end

rescue PrecompileRequired
info("Skipping asset precompile, no asset diff found")
rescue PrecompileRequired => e
warn(e.message)
execute(:rake, "assets:precompile")
end
end
Expand Down