Sdmext279/read document #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test cases added for readDocument in sdm.js
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yashmeet29
reviewed
May 7, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
yashmeet29
requested changes
May 7, 2024
yashmeet29
requested changes
May 7, 2024
lib/handler/index.js
Outdated
| async function readDocument(Key, token, uri){ | ||
| const { repositoryId } = getConfigurations(); | ||
| const documentReadURL = uri+ "browser/" + repositoryId + "/root?objectID=" + Key + "&cmisselector=content"; | ||
| console.log('Check url: ', documentReadURL); |
There was a problem hiding this comment.
Pls remove the console
lib/sdm.js
Outdated
| const content = await readAttachment(Key, token, this.creds); | ||
| return content; | ||
| } | ||
| throw new Error("Url not found"); |
There was a problem hiding this comment.
can we put this message in message constant file
yashmeet29
reviewed
May 8, 2024
lib/handler/index.js
Outdated
Comment on lines
5
to
7
| async function readAttachment(Key,token,credentials) { | ||
| try { | ||
| const document = await readDocument(Key,token,credentials.uri) |
There was a problem hiding this comment.
Please add spaces after commas in readAttachment() & readDocument()
yashmeet29
reviewed
May 8, 2024
lib/sdm.js
Outdated
| } = require("../lib/persistence"); | ||
| const { duplicateFileErr } = require("./util/messageConsts"); | ||
| const { fileNotFoundErr } = require("./util/messageConsts"); |
yashmeet29
approved these changes
May 8, 2024
rashmiangadi11
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.tools.sap/browse/SDMEXT-279
This PR covers Read Attachment use-case & UTs.