SDMEXT354/Capability to attach same document to different entities #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmeet29
requested review from
maheshsooryambylu,
rashmiangadi11,
rishikunnath2747 and
dheerasameerk
| const response = await axios.get(getFolderByPathURL, config); | ||
| return response.data.properties["cmis:objectId"].value; | ||
| } catch (error) { | ||
| return null; |
There was a problem hiding this comment.
can we add console.log(error) here
lib/handler/index.js
Outdated
| @@ -64,7 +120,7 @@ async function createAttachment(data, credentials, token, attachments) { | |||
| return response; | |||
| } | |||
|
|
|||
| async function deleteAttachment(credentials, token, objectId, attachments) { | |||
| async function deleteAttachmentOrFolder(credentials, token, objectId) { | |||
There was a problem hiding this comment.
pls rename it to deleteAttachmentsOfFolder
lib/sdm.js
Outdated
| this.isFileNameDuplicateInDrafts(attachment_val); | ||
| if (duplicateDraftFilesErrMsg != "") { | ||
| req.reject(409, duplicateDraftFileErr(duplicateDraftFilesErrMsg)); | ||
| } | ||
| //verify if duplicates exist for the drafts | ||
| const duplicateFilesErrMsg = await this.isFileNameDuplicate( |
There was a problem hiding this comment.
this will not be required now right as other entities you can add same files so we can remove this check
There was a problem hiding this comment.
This check is for the case when user attaches same document multiple times in draft state.
Fix for this Bug: https://jira.tools.sap/browse/SDMEXT-383
There was a problem hiding this comment.
Done. Removed isFileNameDuplicate()
lib/sdm.js
Outdated
| parentId = response.data.succinctProperties["cmis:objectId"]; | ||
| } | ||
| } else { | ||
| parentId = folderIds[0].folderId; |
There was a problem hiding this comment.
can we check if folderIds.? i mean not undefined and length>0
lib/sdm.js
Outdated
| @@ -103,6 +163,13 @@ module.exports = class SDMAttachmentsService extends ( | |||
| if (attachmentsToDelete.length > 0) { | |||
| req.attachmentsToDelete = attachmentsToDelete; | |||
| } | |||
| if (req.event == "DELETE") { | |||
| const folderIds = await getFolderIdForEntity(attachments, req); | |||
| if (folderIds.length > 0) { | |||
There was a problem hiding this comment.
check for undefined also
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rishikunnath2747
approved these changes
May 23, 2024
rashmiangadi11
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.tools.sap/browse/SDMEXT-354
Bug: https://jira.tools.sap/browse/SDMEXT-381
Bug: https://jira.tools.sap/browse/SDMEXT-383
This PR includes: