fix: added top level property entityTypes

[aramovic79]

No description provided.

[swennemers]

generally looks good, please fix the bug mentioned

[aramovic79]

@zongqichen @swennemers @Fannon : As I've already informed you, if you run the service(in terminal, on path plugins/ORD/xmpl cds run or cds watch), the generated ORD document(http://localhost:4004/open-resource-discovery/v1/documents/1) will have 2 errors when validated in the the API Metadata Validator. This PR should not be merged until we have proper values of level included into the ORD schema.

[aramovic79]

@zongqichen @swennemers @Fannon : As I've already informed you, if you run the service(in terminal, on path plugins/ORD/xmpl cds run or cds watch), the generated ORD document(http://localhost:4004/open-resource-discovery/v1/documents/1) will have 2 errors when validated in the the API Metadata Validator. This PR should not be merged until we have proper values of level included into the ORD schema.

This is the reason why I kept this PR to be Draft. Still, @Fannon && @zongqichen , it would be 🚀 if you could review it. Thanks in advance!

[zongqichen]

We need to take care of this logic here, if version is not a valid semantic version, we should not return this invalid version, it will be failed by the validator. Instead, maybe return the default value like 1.0.0. I would expect logger level to error.

[aramovic79]

The default version is not an option. Maybe we should throw an exception in case of non-valid version?

[zongqichen]

I think so, at least we should not provide invalid value. However, I assume this case is really rare in production environment, since we have validator protect us.

[aramovic79]

If you look at the line above the if (!SEM_VER....)) {, you can see the comment: TODO: version can be stated/overwritten by annotation
Simon told me to keep it that way until we clarify how the version should be set by the model/app-owners.
To his opinion, the right way would be to use an annotation, but he told me to keep it this way for now.
Therefore, I would keep the logger(and not throwing the exception) for now until we have the final statement about the version.

All reported findings are addressed.

[zongqichen]

LGTM