Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json instead of josn #18

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix: json instead of josn #18

merged 4 commits into from
Dec 12, 2024
+9 −9

Conversation

David-Kunz
Copy link
Contributor

No description provided.

@David-Kunz David-Kunz requested a review from sjvans December 11, 2024 13:54
sjvans
sjvans reviewed Dec 12, 2024
View reviewed changes
cds-plugin.js Outdated Show resolved Hide resolved
@sjvans sjvans requested a review from alperdedeoglu December 12, 2024 08:32
@sjvans
Copy link
Contributor

sjvans commented Dec 12, 2024

@David-Kunz @alperdedeoglu why did we respond with Authentication Failed instead of the standard Unauthorized?

@alperdedeoglu
Copy link
Contributor

@David-Kunz @alperdedeoglu why did we respond with Authentication Failed instead of the standard Unauthorized?

As far as I remember there was no specific reason. Standard 401 HTTP Unauthorized looks much better.

@sjvans sjvans mentioned this pull request Dec 12, 2024
Open
@sjvans sjvans merged commit 59199b5 into main Dec 12, 2024
5 checks passed
@sjvans sjvans deleted the fix-josn branch December 12, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvans sjvans sjvans approved these changes

@alperdedeoglu alperdedeoglu alperdedeoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@David-Kunz @sjvans @alperdedeoglu