generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added limitations for compositions of one #729
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c027f8c
added limitations for compositions of one
OlenaTi c23d6f9
add David's comments Update cds/cdl.md
nkaputnik 7505db4
review fix
OlenaTi 75856d9
Merge branch 'main' into composition-of-one-limitations
etimr e969b5d
review fix
OlenaTi 83bcbd0
Merge branch 'main' into composition-of-one-limitations
etimr 27de529
Merge branch 'main' into composition-of-one-limitations
etimr 49cf4f9
Merge branch 'main' into composition-of-one-limitations
etimr 0435d91
added entity
OlenaTi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this depends very much on wether we are talking about a composition of one entity or a composition of one aspect.
The may in difference is that for a composition of one entity the foreign key is on the parent side where as for a composition of one entity the foreign key is on the target side. This makes compositions of one aspect more friendly wrt. modifications over paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a runtime expert, but my assumption is that the restrictions mentioned here only apply to "composition of one entity" - correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback Adrian @agoerler, I've added the word
entity
to make limitations more clear.Steffen @stewsk, you are right, I'm writing about entities here.