Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review java documentation #703

Merged
merged 26 commits into from
Mar 11, 2024
Merged

Review java documentation #703

merged 26 commits into from
Mar 11, 2024

Conversation

BraunMatthias
Copy link
Contributor

@BraunMatthias BraunMatthias commented Feb 23, 2024

@chgeo
Copy link
Member

chgeo commented Feb 23, 2024

@BraunMatthias I have resolved the merge conflicts that I caused with my parallel refactoring of index.data.js to .ts files. Sorry for the confusion.

Please pull this PR + the internal repo and you should have a consistent state.
There are still a number of broken links, but that is you work in progress I guess.

@chgeo
Copy link
Member

chgeo commented Feb 23, 2024

Hm.. looking at it.. still too many diffs not caused by you. I guess I need to go back to square one and do the merge from main again. Sorry, stay tuned..

@chgeo chgeo force-pushed the review-java-documentation branch from ace7fe4 to cf60467 Compare February 23, 2024 16:29
@chgeo
Copy link
Member

chgeo commented Feb 23, 2024

Alright, this should now be your intended state, i.e. only your changes.
→ Please pull the PR again.

Now, for all file moves and renames, this is quite incompatible to the current URLs. You need to at least add redirect_from: <old-URL> frontmatter to be compatible.

Still, all links to the old URLs need to be adjusted as these need to use the new URL pattern.

We can also discuss how to handle this...

@BraunMatthias
Copy link
Contributor Author

Yes, redirect links have to be added in a step afterwards. But I wanted just to see and discuss the result in a preview.

@BraunMatthias BraunMatthias force-pushed the review-java-documentation branch from 4b952ad to ef52090 Compare March 5, 2024 13:25
@renejeglinsky renejeglinsky enabled auto-merge (squash) March 11, 2024 07:53
@renejeglinsky renejeglinsky merged commit 4f04bfb into main Mar 11, 2024
4 checks passed
@renejeglinsky renejeglinsky deleted the review-java-documentation branch March 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants