Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the absence of virtual elements in the Result #486

Closed
wants to merge 2 commits into from

Conversation

vmikhailenko
Copy link
Contributor

As discussed: mention in the migration guide that virtual elements are no longer available.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling Mistakes

  • ./java/migration.md:374:6 Unknown word "Vitrual"

Generally, for each spelling mistake there are 2 ways to fix it:

  1. Fix the spelling mistake and commit it.
  2. The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.

java/migration.md Outdated Show resolved Hide resolved
@vmikhailenko vmikhailenko requested a review from agoerler October 17, 2023 14:03
@@ -371,6 +371,10 @@ result.rowCount(2); // 0 matches with ID 0

The default value of CDS Property `cds.security.authentication.normalizeProviderTenant` is changed to `true`. With this change, the provider tenant is normalized and set to `null` in the UserInfo by default. If you have subscribed the provider tenant to your application you need to disable this feature.

#### Virtual elements

The values for an elements annotated with the annotation `@Core.Computed: true`, notably, the virtual elements are no longer retained after the CQN statement execution. Previously this was the case only for an `Upsert` statement. Their values are no longer returned in the `Result` of the CQN statement and are not available in the `@After` handlers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The values for an elements annotated with the annotation `@Core.Computed: true`, notably, the virtual elements are no longer retained after the CQN statement execution. Previously this was the case only for an `Upsert` statement. Their values are no longer returned in the `Result` of the CQN statement and are not available in the `@After` handlers.
The values for (virtual) elements annotated with the annotation `@Core.Computed: true` are no longer retained after the CQN statement execution. Their values are no longer returned in the `Result` of the CQN statement and are not available in the `@After` handlers. Previously this was the case only for `Upsert` statements.

@@ -371,6 +371,10 @@ result.rowCount(2); // 0 matches with ID 0

The default value of CDS Property `cds.security.authentication.normalizeProviderTenant` is changed to `true`. With this change, the provider tenant is normalized and set to `null` in the UserInfo by default. If you have subscribed the provider tenant to your application you need to disable this feature.

#### Virtual elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Virtual elements
#### Virtual Elements

@vmikhailenko vmikhailenko deleted the java-migration-virtual-elements branch November 7, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants