Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript.md #1495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update typescript.md #1495

wants to merge 2 commits into from

Conversation

czindel-sap
Copy link

Sorry I know this is not a proper text, but I wanted to highlight the misleading description

Sorry I know this is not a proper text, but I wanted to highlight the misleading description
@renejeglinsky
Copy link
Contributor

I'm sorry but I'm not getting the point here. Do you want to point out, that this sentence is only valid since a certain release?

@czindel-sap
Copy link
Author

@renejeglinsky I experienced that the types where not there and that I needed to install @cap-js/cds-types. So the documentation is not correct in that point for my understanding. I think https://cap.cloud.sap/docs/releases/jun24#cds-types-dependency explains what changed

@renejeglinsky
Copy link
Contributor

I understand now, thanks!
@daogrady That means we need to adapt the whole section, right?

@daogrady
Copy link
Contributor

I understand now, thanks! @daogrady That means we need to adapt the whole section, right?

I am not aware of any other places where it is claimed that the types are automatically installed

@renejeglinsky
Copy link
Contributor

So imports are still done through @sap/cds? The only thing one needs to do is npm add @cap-js/cds-types?

@daogrady
Copy link
Contributor

That is correct, yes. We outlined this as part of the migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants