Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docu for @Common.FieldControl validation #1474

Merged
merged 13 commits into from
Dec 6, 2024

Conversation

mariayord
Copy link
Contributor

@mariayord mariayord commented Nov 27, 2024

@mariayord
Copy link
Contributor Author

@renejeglinsky Do you have an idea why the job is failing ? The broken links are not related with my changes.

@@ -926,6 +926,12 @@ entity Foo {
```


### `@Common.FieldControl` {#common-fieldControl}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather add that after @mandatory/readonly section as this belongs together.
In addition, we could add that as a warning that numeric and dynamic values are not evaluated by the runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johannes-vogel I thought it is good to be added right before 'Custom logic' ,as if they are numeric the customer has to use the custom logic.

@chgeo
Copy link
Member

chgeo commented Nov 28, 2024

Do you have an idea why the job is failing ? The broken links are not related with my changes.

This is fixed.

@chgeo
Copy link
Member

chgeo commented Dec 3, 2024

Will address the broken links @mariayord

@mariayord
Copy link
Contributor Author

mariayord commented Dec 3, 2024

@chgeo I don't understand what is going on with the links. I see now Daniel added a space between assert and .unique @assert .unique. I will change this also for FieldControl ... I have to correct also the link for FieldControl

@chgeo
Copy link
Member

chgeo commented Dec 3, 2024

@mariayord this is tricky because we use special characters like @ in the heading for which VitePress computes different anchors like common-fieldcontrol than the MD editor in VS Code (commonfieldcontrol) . See the difference? ;)

So either

  • Use plain names in titles
  • Or add additional anchors like here.

@mariayord
Copy link
Contributor Author

mariayord commented Dec 3, 2024

@chgeo OK, in this case I have to add again the anchor... Thanks!
The space between names in annotations is strange for me, is there any reason ?

guides/providing-services.md Outdated Show resolved Hide resolved
@renejeglinsky renejeglinsky added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit a328148 Dec 6, 2024
4 checks passed
@renejeglinsky renejeglinsky deleted the add-common-fieldControl-doc branch December 6, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants