Fix outdated audit logging config (#1442) #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjvans
reviewed
Nov 15, 2024
| @@ -492,7 +492,7 @@ This transparently applies to all implementations, even [custom implementations] | |||
| { | |||
| "audit-log": { | |||
| "[development]": { | |||
| "impl": "@cap-js/audit-logging/srv/audit-log-to-console", | |||
| "kind": "audit-log-to-console", | |||
There was a problem hiding this comment.
Suggested change
| "kind": "audit-log-to-console", |
|
thanks @grenik @renejeglinsky we no longer disable the outbox in development, so the sentence
is incorrect. maybe adjust to
and remove the kind, as suggested in #1443 (comment)? |
|
→ #1446 |
renejeglinsky
added a commit
that referenced
this pull request
Nov 26, 2024
re #1443 --------- Co-authored-by: Rene Jeglinsky <[email protected]>
|
I think all changes from this PR have been done in the other PR, so I'm closing it here. All the best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1442