[REVIEW] Reviewing implementation #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjoa
changed the title
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jun 29, 2023
| @@ -5,67 +5,62 @@ const { augmentContext, calcMods4Before, calcMods4After, emitMods } = require('. | |||
| const { hasPersonalData } = require('./lib/utils') | |||
|
|
|||
| // TODO: why does cds.requires.audit-log: false in sample package.json not work ootb?! | |||
| // REVIST: It does, doesn't it? | |||
There was a problem hiding this comment.
cds.env.requires['audit-log'] is false, but a cds.connect.to('audit-log') still works, so audit-logging is not "deactivated" (calculated in any case is an additional issue)...
There was a problem hiding this comment.
connect does cds.requires || cds.requires.kinds
sjvans
reviewed
Jun 29, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
reviewed
Jul 4, 2023
sjvans
changed the title
|
review decisions applied in #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE YET
→ let's use this for a joint review
to decide/ do before release of 0.1.0
emit[ ] check logs in fiori tests (see comments "// TODO: check if this is correct")-> adjust fiori tests to logging on draftEdit and draftActivate #10[ ] tests with-> test with@cap-js/sqlite@cap-js/sqlite#9[ ] finalize docs-> in progress. not tracked here.optional
[ ] provider audit logs?-> currently in discussion, follow-ups as needed