Change drawSvg to be synchronous

[MatheusrdSantos]

No description provided.

[Sharcoux]

For me, you missed half of the point.

We want to expose the same API as Images. This means that you need and embedSvg that will return a PDFSvg object method and a drawSvgSync that will take that PDFSvg and draw it on the pdf page.

Your methods also seem to be misplaced between PDFPage and svg. The method drawSvg from svg has no more reason to be async and should be made sync. No need to create a drawSvgAsync here.

[MatheusrdSantos]

I fixed the implementation, but it's a bit different from your suggestion. I didn't implement the PDFSvg class because it would be a breaking change of the current drawSvg api.

[Sharcoux]

This should have this signature: drawSvg(page: PDFPage, svg: PDFSvg, options: PDFPageDrawSVGElementOptions)

type PDFSvg = {
  svg: string,
  images: Record<string, image>
}

[Sharcoux]

Should not be part of the options

[Sharcoux]

If we want to avoid breaking changes, this method can't be made sync, because it is exposed to the public. But we could decide to make a breaking change. In this case, we should change the signature of this method to drawSvg(svg: PDFSvg, options: PDFPageDrawSVGElementOptions)

In case you want to go with the no breaking change option, you'd need to create the method:

drawSvgSync(svg: PDFSvg, options: PDFPageDrawSVGElementOptions): void {
  drawSvg(this, svg, options)
}

async drawSvg(svg: string, options: PDFPageDrawSVGElementOptions): void {
  const svgPdf = await embedSvg(svg)
  this.drawSvgSync(svgPdf, options)
}

The other option would lead to only:

drawSvg(svg: PDFSvg, options: PDFPageDrawSVGElementOptions): void {
  drawSvg(this, svg, options)
}

Of course, you can keep the asserts and detail the options like in the current code