Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.7.0 #323

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Release 1.7.0 #323

merged 3 commits into from
Dec 15, 2023

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Dec 5, 2023 •
edited
Loading

@Saviq Saviq changed the title release: changelog and version bump Release 1.7.0 Dec 14, 2023
@Saviq Saviq requested review from RAOF and AlanGriffiths December 14, 2023 12:40
@Saviq
Copy link
Collaborator Author

Saviq commented Dec 14, 2023

@RAOF @AlanGriffiths anything else we want in the release?

AlanGriffiths
AlanGriffiths approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is unexpected, but looks legit.

No idea if there pending PRs that ought to be included

@Saviq
Copy link
Collaborator Author

Saviq commented Dec 14, 2023

@AlanGriffiths the actual diff is this:

https://github.com/MirServer/wlcs/compare/main..release/1.7

On the PR, GH shows a sum of the commits, not the diff against the target.

RAOF
RAOF approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have anything else to cherry-pick; this is a useful improvement, and fine to release now.

@Saviq Saviq added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 6812219 Dec 15, 2023
33 checks passed
@Saviq Saviq deleted the release/1.7 branch December 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@RAOF RAOF RAOF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saviq @RAOF @AlanGriffiths