Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using the image container with lazyloaded images #5403

Merged

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Oct 30, 2024

Done

Specifically targets .lazyloaded images for display: contents to avoid applying contents display to .lazyload

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@jmuzina jmuzina added Review: QA needed Review: Code needed Bug 🐛 Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 30, 2024
@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review October 30, 2024 15:53
@jmuzina jmuzina requested a review from bartaz October 30, 2024 15:53
bartaz
bartaz previously approved these changes Oct 30, 2024
@jmuzina jmuzina force-pushed the 5402-image-aspect-ratio-lazyloaded-fix branch from a5f3956 to 2413dde Compare October 30, 2024 16:00
@jmuzina jmuzina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 30, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmuzina jmuzina merged commit 0a577f5 into canonical:main Oct 30, 2024
10 checks passed
@jmuzina jmuzina deleted the 5402-image-aspect-ratio-lazyloaded-fix branch October 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants