Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-17303] Updating the "Free Trial Available" badge on Pro store page #14516

Merged

Conversation

fasih-mehmood
Copy link
Contributor

@fasih-mehmood fasih-mehmood commented Nov 29, 2024

Done

  • Remove Free trial available hyperlink.
  • Change copy to Free trial on checkout.

QA

Issue / Card

Fixes WD-17303

Screenshots

Before:

image

After:

image

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (288260f) to head (e110b6e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14516   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         120      120           
  Lines        3419     3419           
  Branches     1174     1174           
=======================================
  Hits         2381     2381           
  Misses       1013     1013           
  Partials       25       25           
Files with missing lines Coverage Δ
...react/components/ProductSummary/ProductSummary.tsx 92.30% <ø> (ø)

Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fasih-mehmood fasih-mehmood merged commit 69d7a14 into canonical:main Nov 29, 2024
16 checks passed
@fasih-mehmood fasih-mehmood deleted the wd-17303-update-free-trial-copy branch November 29, 2024 05:40
mtruj013 pushed a commit to mtruj013/ubuntu.com that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants