-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: /ceph/install redesign #14511
feat: /ceph/install redesign #14511
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-ceph #14511 +/- ##
========================================================
+ Coverage 69.64% 69.76% +0.12%
========================================================
Files 120 120
Lines 3419 3426 +7
Branches 1178 1177 -1
========================================================
+ Hits 2381 2390 +9
+ Misses 1013 1012 -1
+ Partials 25 24 -1 |
@@ -27,8 +27,8 @@ <h3 class="p-heading--5"> | |||
</section> | |||
|
|||
<script src="{{ versioned_static('js/dist/latest-news.js') }}"></script> | |||
{# djlint:off #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
djlint will ignore this if it's set within the script
Thank you! A few comments:
|
ty @mtruj013 ! just one question from me:
|
Thanks @mattea-turic and @eliman11, ready for another look! |
Looks good thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done
/_latest-blogs_download.html
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-16347