-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build page on /ai/mlops-workshop #14474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14474 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 120 120
Lines 3419 3419
Branches 1174 1174
=======================================
Hits 2381 2381
Misses 1013 1013
Partials 25 25 |
Thanks @minkyngkm ! I was awaiting some feedback from the PM before marking the page as ready for development so there might be quite a few changes from where it is currently, but I appreciate you already building it :) Here's the figma file for reference, and I've added the assets to this server. I'm not sure if it would be helpful for you if I write out the changes that need to be made, or if you can work from the figma file and then I'll leave comments if there are any further changes to be made. Lmk what works for you! |
Thanks @mattea-turic. I've made some changes according to the design. Hopefully it looks better now :) |
Thank you @minkyngkm ! Just a couple comments:
|
Hi @minkyngkm, thank you! A few changes:
Also deferring to @mattea-turic but the spacing on the equal heights row section looks off to me on mobile and tablet. |
@mattea-turic @eliman11 I have addressed most of the issues. Please let me know if there is something I missed or if something else needs changing |
Looks good to me, thanks @abhigyanghosh30! |
Thank you so much @mtruj013 @mattea-turic for reviewing! I've made some changes according to your suggestions. Hopefully it looks better now! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @minkyngkm ! A few more and then this is good to go :)
templates/ai/mlops-workshop.html
Outdated
<hr class="p-rule" /> | ||
<h2 class="p-section--shallow">Why join an MLOps workshop?</h2> | ||
</div> | ||
<div class="row--25-75 is-split-on-medium"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think mine and Mattea's comments here were missed. We should use offsets here instead of an empty div and define medium cols which won't work with the 25-75
grid short hard. Suggested edits below:
Thanks @mtruj013, applied all the suggestions! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @minkyngkm !!
Looks good @minkyngkm , thanks! |
Done
QA
Issue / Card
Fixes #https://warthogs.atlassian.net/browse/WD-16670