Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build page on /ai/mlops-workshop #14474

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Build page on /ai/mlops-workshop #14474

merged 6 commits into from
Dec 2, 2024

Conversation

minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented Nov 13, 2024

Done

  • Build page on /ai/mlops-workshop

QA

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-16670

@webteam-app
Copy link

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (21a2c39) to head (c7411cd).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14474   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         120      120           
  Lines        3419     3419           
  Branches     1174     1174           
=======================================
  Hits         2381     2381           
  Misses       1013     1013           
  Partials       25       25           

see 1 file with indirect coverage changes

@mattea-turic
Copy link
Collaborator

Thanks @minkyngkm ! I was awaiting some feedback from the PM before marking the page as ready for development so there might be quite a few changes from where it is currently, but I appreciate you already building it :)

Here's the figma file for reference, and I've added the assets to this server.

I'm not sure if it would be helpful for you if I write out the changes that need to be made, or if you can work from the figma file and then I'll leave comments if there are any further changes to be made. Lmk what works for you!

@minkyngkm
Copy link
Contributor Author

Thanks @mattea-turic. I've made some changes according to the design. Hopefully it looks better now :)

@mattea-turic
Copy link
Collaborator

mattea-turic commented Nov 18, 2024

Thank you @minkyngkm ! Just a couple comments:

  • Each of the images should have a 3% background at #000000
  • Remove the hr that's right below the "You can expect:" in the first subsection of the "Why join an MLOps workshop?" section pls
Screenshot 2024-11-18 at 01 53 22
  • Add shallow padding bottom for the feature block of the "MLOps workshop structure" section (see figma if my explanation here doesn't make sense :'))
Screenshot 2024-11-18 at 01 55 30
  • "Learn more" section should have hrs between the resource items
  • Also, for smaller screen sizes, would it be possible to use wrapping to force the link below the button? It looks a little odd with it spanning two lines i.e.
Screenshot 2024-11-18 at 01 59 33

@eliman11
Copy link

eliman11 commented Nov 18, 2024

Hi @minkyngkm, thank you! A few changes:

  • Sorry I had forgotten to delete my draft from Figma! Could you please delete the first section under the hero?
Screenshot 2024-11-18 at 09 57 56
  • Match the last column in the equal heights row section to the copydoc - heading should be 'Edge AI' and description should be 'Develop Edge AI architecture to efficiently run and maintain your models on a variety of devices.'
Screenshot 2024-11-18 at 11 08 49
  • Change h4 heading tags in the equal heights row section to h3 without changing the styling
  • Match description under first link in the 'Learn more' section with copydoc: 'Explore how Canonical delivered significant cost-savings in moving away from licensed providers and proprietary solutions.'

Also deferring to @mattea-turic but the spacing on the equal heights row section looks off to me on mobile and tablet.
Screenshot 2024-11-18 at 11 14 01
Screenshot 2024-11-18 at 11 14 37

@abhigyanghosh30
Copy link
Contributor

@mattea-turic @eliman11 I have addressed most of the issues. Please let me know if there is something I missed or if something else needs changing

@eliman11
Copy link

Looks good to me, thanks @abhigyanghosh30!

@minkyngkm
Copy link
Contributor Author

minkyngkm commented Nov 27, 2024

Thank you so much @mtruj013 @mattea-turic for reviewing! I've made some changes according to your suggestions. Hopefully it looks better now! 🙏

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @minkyngkm ! A few more and then this is good to go :)

templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
<hr class="p-rule" />
<h2 class="p-section--shallow">Why join an MLOps workshop?</h2>
</div>
<div class="row--25-75 is-split-on-medium">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think mine and Mattea's comments here were missed. We should use offsets here instead of an empty div and define medium cols which won't work with the 25-75 grid short hard. Suggested edits below:

templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
templates/ai/mlops-workshop.html Show resolved Hide resolved
templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
templates/ai/mlops-workshop.html Show resolved Hide resolved
templates/ai/mlops-workshop.html Outdated Show resolved Hide resolved
templates/ai/mlops-workshop.html Show resolved Hide resolved
@minkyngkm
Copy link
Contributor Author

Thanks @mtruj013, applied all the suggestions! 🙏

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @minkyngkm !!

@mattea-turic
Copy link
Collaborator

Looks good @minkyngkm , thanks!

@akbarkz akbarkz merged commit 43fa2ee into canonical:main Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants