Skip tls config when passthrough is enabled #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-scribner
reviewed
Nov 29, 2024
There was a problem hiding this comment.
The solution here fixes #425, but I lack context to know if it is an appropriate solution or too narrow. See the comments in the review for more details. We can discuss there or offline to sort this out
dstathis
approved these changes
Dec 2, 2024
ca-scribner
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #425
Solution
Skip the generation of tls dynamic config in traffic when passthrough is set
Context
When
tls.passthrough: trueis set for a route, Traefik forwards the raw TLS traffic directly to the backend service without terminating the TLS connection.This means Traefik doesn't need to handle certificates, nor does it need additional TLS configuration
Testing Instructions
1- juju deploy traefik-k8s
2- juju deploy wazuh-server-operator
3- juju relate traefik-k8s wazuh-server-operator
4- Fetch traefik's dynamic config and validate no tls entry is created and main entry has
tls.passthrough: true