CSS-10666: Add enable DB tls config #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelkawi-a
force-pushed
the
css-10666-tls
branch
4 times, most recently
from
85e116a to
b9e2264
Compare
kelkawi-a
force-pushed
the
css-10666-tls
branch
from
b9e2264 to
7191153
Compare
mertalpt
reviewed
Sep 16, 2024
onurmus
approved these changes
Sep 16, 2024
kelkawi-a
force-pushed
the
css-10666-tls
branch
from
93961d1 to
2a76c9d
Compare
kelkawi-a
force-pushed
the
css-10666-tls
branch
from
2a76c9d to
a7e50f0
Compare
kelkawi-a
force-pushed
the
css-10666-tls
branch
from
8102128 to
4e363b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
db-tls-enabledconfig, which allows the user to specify whether or not the persistence and visibility database has TLS enabled. It also updates the integration tests and workflows in line with recent updates made to our charms.Note: I've disabled one of the integration tests which tests that a server upgrade from v1.20 to v1.21 will result in a schema upgrade. This is due to a bug in pylibjuju in how charms are deployed from Charmhub with custom resources, which will need to be investigated later. In any case, the changes introduces here do not have any effect on this process.