This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
[WIP] Add nginx #84
Closed
[WIP] Add nginx #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
when this closes, we can merge canonical/grafana-k8s-operator#323 |
mmkay
commented
Apr 15, 2024
| nginx-image: | ||
| type: oci-image | ||
| description: OCI image for nginx | ||
| upstream-source: nginx:latest |
There was a problem hiding this comment.
Idea: how about we keep it at 1.25 so that the version isn't floating too far? https://hub.docker.com/_/nginx
This would mean that we'll need to make sure we upgrade it later but at least we'd have some control over it.
mmkay
commented
Apr 15, 2024
| @@ -556,6 +564,7 @@ def _get_requested_protocols(relation: Relation): | |||
| try: | |||
| databag = TracingRequirerAppData.load(relation.data[app]) | |||
| except (json.JSONDecodeError, pydantic.ValidationError, DataValidationError): | |||
| logger.exception("What was that error again?") | |||
There was a problem hiding this comment.
My leftover, guess we can get rid of it ;)
|
Closing this in favour of #94. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
Testing Instructions
Build tempo from the PR: [WIP] Add nginx by mmkay · Pull Request #84 · canonical/tempo-k8s-operator
Build loki from branch: GitHub - canonical/loki-k8s-operator at tracing-v2
Deploy traefik from edge
juju deploy traefik-k8s --channel=edge traefikcross-relate:
jhack imatrix fillRelease Notes