Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a catalogue endpoint #93

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add a catalogue endpoint #93

merged 4 commits into from
Dec 18, 2024

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Dec 17, 2024 •
edited
Loading

Fixes #87

This PR adds a catalogue relation that points to Tempo's memberlist UI (Tempo doesn't expose other UIs that can used).

Context

TODO:

Testing Instructions

  1. Deploy Tempo HA
  2. Deploy Catalogue
  3. juju integrate tempo:catalogue catalogue
  4. Open catalogue UI
  5. You should see an entry for Tempo that redirects to <tempo_ip>:3200/memberlist UI
    image
    Not bad 😃
    image

Drive-bys

  • Fix scenario fixture that deletes runtime-created alert rules files

@michaeldmitry michaeldmitry requested a review from a team as a code owner December 17, 2024 12:10
@michaeldmitry michaeldmitry mentioned this pull request Dec 17, 2024
Merged
@sed-i
Copy link
Contributor

sed-i commented Dec 17, 2024

Is this closing #87?

@michaeldmitry
Copy link
Contributor Author

Is this closing #87?

Ah, yes. Updated the description

@michaeldmitry michaeldmitry mentioned this pull request Dec 18, 2024
Open
1 task
@michaeldmitry michaeldmitry merged commit b4630c7 into main Dec 18, 2024
13 checks passed
@michaeldmitry michaeldmitry deleted the TAP-158 branch December 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkay mmkay mmkay approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add catalogue relation
3 participants
@michaeldmitry @sed-i @mmkay