-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable service graph processor #77
Conversation
TODO:
|
update: we're propagating the datasource UIDs to the sources themselves as planned, but instead of sending the uids through remote_write and loki_push_api, we're adding a new |
bd2e236
to
30171ae
Compare
Testing Instructions
TODO
|
1158b84
to
0920e3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's looking good, a little bit of polishing here and there and then it's good to go
@michaeldmitry FYI I can't approve it because I'm the owner of the PR technically |
Co-authored-by: PietroPasotti <[email protected]> Signed-off-by: Michael Dmitry <[email protected]>
it works
but the loki/prom datasource UIDs are hardcoded in the coordinator charm.
Reason for that is ATM we have no way to determine the datasource UIDs for 'other' datsources than ourselves.
We likely need a new relation interface or a clever solution.