Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure func tests log both stdout and stderr #252

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Ensure func tests log both stdout and stderr #252

merged 1 commit into from
Sep 25, 2024

Conversation

dosaboy
Copy link
Member

@dosaboy dosaboy commented Sep 25, 2024

Juju 2 prints output to stderr as opposed to stdout in Juju 3 so need to pipe both to logs.

@dosaboy
Ensure func tests log both stdout and stderr
5d65747 
Juju 2 prints output to stderr as opposed to stdout
in Juju 3 so need to pipe both to logs.
@dosaboy dosaboy requested a review from pponnuvel September 25, 2024 09:32
pponnuvel
pponnuvel approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@pponnuvel pponnuvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosaboy dosaboy merged commit 7cc5c23 into canonical:main Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pponnuvel pponnuvel pponnuvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dosaboy @pponnuvel