Separate relations into separate yaml document #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI this change is compatible with older juju versions (ie 2.x). |
nicolasbock
requested changes
Nov 27, 2023
nicolasbock
approved these changes
Nov 28, 2023
nicolasbock
force-pushed
the
fix-juju3-relations
branch
3 times, most recently
from
3ec5687 to
6fe376b
Compare
To adjust to new juju 3.2 behaviour that does not allow relations referencing overlay applications in the base bundle. Ref: https://bugs.launchpad.net/juju/+bug/2041785 Resolves: canonical#149 Co-authored-by: Nicolas Bock <[email protected]>
nicolasbock
force-pushed
the
fix-juju3-relations
branch
from
6fe376b to
08ed196
Compare
|
I only just caught up on this one and just wanted to note that using --- to start a new yaml document within the same file is a fantastic hack. I had solved this in my local branch by deploying an overlay/blank.yaml as the base bundle, and then passing in the real base bundle (e.g. openstack.yaml) as the first overlay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To adjust to new juju 3.2 behaviour that does not
allow relations referencing overlay applications
in the base bundle.
Ref: https://bugs.launchpad.net/juju/+bug/2041785
Resolves: #149