google: mark cache as ready after it got populated #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The googleImagesCache is currently not marked `ready` AFAICT. This means while it is correctly build it is not used in subsequent calls to projectImages(). This commit set the cache to ready after it got populated.
mvo5
force-pushed
the
fix-google-cache-usage
branch
from
c011683
to
344f093
Compare
mvo5
force-pushed
the
fix-google-cache-usage
branch
from
344f093
to
0b21f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The googleImagesCache is currently not marked
ready. This means while it is correctly build it is not used in subsequent calls to projectImages(). This commit set the cache to ready after it got populated.The first commit fixes the issue, the second adds the test that shows the behavior. Happy to talk about the test more, it makes google a bit easier to test but maybe you prefer a different approach :)