qemu: allow specifying the machine type #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows QEMU machine types to be used other than the default "pc", such as "q35". Valid alternative machine types can be identified with the `qemu-system-x86_64 -M help` command. Signed-off-by: Isaac True <[email protected]>
mvo5
reviewed
May 2, 2023
|
|
||
| // Type of machine emulated, only for qemu. Defaults to "pc", which is | ||
| // the QEMU default for x86_64 | ||
| MachineType string `yaml:"machine-type"` |
There was a problem hiding this comment.
We try to avoid backend specific options in System, if possible we try to find a generic term that could be reused across various backends. MachineType (or just Machine) is actually not bad as it potentially maps to many different backends, e.g. in linode or google it could map to the machine type like: e2-standard-2. Three is an existing Plan in project.go that is currently used for this.
Which makes me wonder if could consolidate plan and machine somehow, I see some optons:
- add new
machineand only use in qemu - use
planin the qemu backend and map that to machine type - add new
machineand use it in linode/google instead ofplan(deprecateplan) - ... something I forgot?
Each has different tradeoffs so input from @niemeyer on this would be best.
There was a problem hiding this comment.
Implemented here: #169
I'll keep this PR open in case we want to go in a different direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows QEMU machine types to be used other than the default "pc", such as "q35". Valid alternative machine types can be identified with the
qemu-system-x86_64 -M helpcommand.This is useful for testing images for embedded systems which may not support the "pc" QEMU machine type, or require features from "q35" or other types.