snapcraft.yaml: update to work with modern snapcraft #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spread is currently not build with snapcraft 5.0 (the default). This commit fixes this by moving to `base: core20`. Note that this also requires moving to `go.mod`.
mvo5
changed the title
sergiusens
reviewed
Mar 16, 2022
| @@ -12,6 +12,7 @@ description: | | |||
|
|
|||
| confinement: strict | |||
| grade: stable | |||
| base: core20 | |||
|
|
|||
| apps: | |||
| spread: | |||
There was a problem hiding this comment.
adding an entry for personal-files to be able to easily use the google backend would be nice.
There was a problem hiding this comment.
Excellent suggestion, I think this would ideally be a followup?
There was a problem hiding this comment.
I addressed this in PR #161 now.
Closed
sergiusens
approved these changes
Feb 6, 2023
Closed
toabctl
reviewed
Feb 7, 2023
| @@ -1,5 +1,5 @@ | |||
| name: spread | |||
| version: 2018.08.21 | |||
| version: 2020.08.19 | |||
There was a problem hiding this comment.
I will do a followup with this change and also the move to core22. This PR got (soft) approval by Gustavo as is so I don't want to add more potentially controversial things just now :)
There was a problem hiding this comment.
I addressed the version in #161 - please let me know if that matches what you had in mind and I'm happy to tweak as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spread is currently not build with snapcraft 5.0 (the default).
This commit fixes this by moving to
base: core20.Note that this also requires moving to
go.modhand hence it includes #129.