Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: stop renaming desktop file #5150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soumyaDghosh
Copy link
Contributor

With snapd 2.66, it supports custom desktop file names. This patch allows it to happen from snapcraft side.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what effect this will have when running a snap on a system with snapd<2.66?

@soumyaDghosh
Copy link
Contributor Author

Do you know what effect this will have when running a snap on a system with snapd<2.66?

As I tested before, snapd will install the file with a <snap_name>, which snapd will do here also if the desktop file names aren't explicitly mentioned before hand. It was never really an issue to fix with.

@soumyaDghosh
Copy link
Contributor Author

I think I'll need to fix the spread tests too.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (654871d) to head (99f4e85).
Report is 642 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (99f4e85). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (99f4e85)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5150      +/-   ##
==========================================
- Coverage   94.88%   89.71%   -5.17%     
==========================================
  Files         658      342     -316     
  Lines       55189    22641   -32548     
==========================================
- Hits        52364    20312   -32052     
+ Misses       2825     2329     -496     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@soumyaDghosh soumyaDghosh force-pushed the stop-rename-desktop-file branch 2 times, most recently from 7b7c0d5 to 2883282 Compare November 23, 2024 05:17
With snapd 2.66, it supports custom desktop file names. This patch allows it to happen from snapcraft side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants