-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions/kde-neon-6: fix XDG_CONFIG_DIRS #5104
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5104 +/- ##
==========================================
- Coverage 94.88% 89.70% -5.18%
==========================================
Files 658 341 -317
Lines 55189 22589 -32600
==========================================
- Hits 52364 20263 -32101
+ Misses 2825 2326 -499 ☔ View full report in Codecov by Sentry. |
Thank you, except this PR needs to be done here: https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration |
Let's merge it here until it's used from here, else we'll not be able to use the change. |
e119025
to
b900513
Compare
@sergiusens @lengau I think we can merge this. The Code Coverage issue is not related to this I think. |
@soumyaDghosh can you please also do a pr here for this https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration |
Very sorry, I forgot about this. It's done! https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration/-/merge_requests/2 |
@sergiusens @lengau kindly merge this... |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)