Add QT extension

[jardon]

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• Have you successfully run make lint?
• Have you successfully run pytest tests/unit?

---

This PR adds support for two QT extensions (6.5 and 5.15)

• Add extension handling
• Update unit tests
• Fixes hardcoded gnome extension script
• Update Extension class to pass in extension name

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d75fdaf) 89.19% compared to head (4d14e4a) 88.35%.
Report is 5 commits behind head on main.

Files	Patch %	Lines
snapcraft/extensions/qt_framework.py	95.83%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
- Coverage   89.19%   88.35%   -0.85%     
==========================================
  Files         322      328       +6     
  Lines       21826    22035     +209     
==========================================
+ Hits        19468    19469       +1     
- Misses       2358     2566     +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mr-cal]

Looks good, nice work!

Can you create a spread test for 5.15 and 6.5 under tests/spread/extensions/? You can use the other spread tests in that directory as a reference.

[mr-cal]

Update for anyone watching:

This PR is waiting on @jardon getting auto-connect approvals for the two qt-framework snaps used by this extension

[jardon]

Store request submitted here

[sergiusens]

you store request has updates

[jardon]

The CI can be rerun when the snapcraft forum post is resolved.

[jardon]

@sergiusens @mr-cal do you know where snapctl is getting the qt-framework slot/plug from? I've renamed it in the snaps themselves after being requested in the forums to change it. I dont see it in any of the desktop launch scripts either.

error: error running snapctl: snap "qt6-6-hello" has no plug or slot named "qt-framework"
ERROR: not connected to the qt-framework content interface.

$ snap connections qt6-6-hello 
Interface                         Plug                                 Slot                                             Notes
content[icon-themes]              qt6-6-hello:icon-themes              gtk-common-themes:icon-themes                    -
content[qt-framework-6-6-core22]  qt6-6-hello:qt-framework-6-6-core22  qt-framework-6-6-core22:qt-framework-6-6-core22  -
content[sound-themes]             qt6-6-hello:sound-themes             gtk-common-themes:sound-themes                   -
desktop                           qt6-6-hello:desktop                  :desktop                                         -
desktop-legacy                    qt6-6-hello:desktop-legacy           :desktop-legacy                                  -
opengl                            qt6-6-hello:opengl                   :opengl                                          -
wayland                           qt6-6-hello:wayland                  :wayland                                         -
x11                               qt6-6-hello:x11                      :x11                                             -
jardon@lagaan:~/Projects/snapcraft$ snap connections qt-framework-6-6-core22 
Interface                         Plug                                 Slot                                             Notes
content[qt-framework-6-6-core22]  qt6-6-hello:qt-framework-6-6-core22  qt-framework-6-6-core22:qt-framework-6-6-core22  -

[jardon]

@mr-cal Can I get the CI kicked back off?

[jardon]

I updated the content snaps to correct the plug check issue

[codecov]

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.38%. Comparing base (d364154) to head (6ce8e13).

❗ Current head 6ce8e13 differs from pull request most recent head e1c49e5. Consider uploading reports for the commit e1c49e5 to get more accurate results

Files	Patch %	Lines
snapcraft/extensions/qt_framework.py	97.18%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
+ Coverage   88.35%   88.38%   +0.02%     
==========================================
  Files         328      329       +1     
  Lines       22015    22088      +73     
==========================================
+ Hits        19452    19523      +71     
- Misses       2563     2565       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mr-cal]

FYI @cmatsuoka, jardon is no longer at Canonical, so I don't think any progress is being made on this. We need to decide what to do with his qt-framework content snaps and this PR.

[jardon]

that is more or less correct. this has been demoted in priority for me, but that doesnt mean that i cant work to get this pushed through.

there are a couple of reasons that i havent worked on this in quite a while. firstly, building and maintaining the sdk and content snaps is unfortunately too big of a burden. i cant build the images in github actions because of resource limitations as well as architecture. yes, theres launchpad, but a new coat of paint doesnt mean its basically abandonware (seriously stand up a gitlab instance and convert all the useful bits of launchpad into a plugin or something). secondly, the current snap architecture increases the amount of work beyond whats reasonable. having to have separate snaps for each combination of QT version and base, dealing with the annoyances of the content interface, as well as dealing with store requests makes this a lot to maintain.

if you can offer good solutions to my issues above, i'd be happy to help.

[jardon]

For some more context here, I originally wanted to partner with the KDE snap people for creating snaps that would be the building blocks for both extensions. Unfortunately, it seems they got busy with the KDE Ubuntu spin and never responded which is another reason why this stalled.

[keshavbhatt]

Any update on this?

[jardon]

@keshavbhatt i have not heard back from canonical

[mr-cal]

Hi @keshavbhatt, we haven't decided on how to proceed with the QT extension and content snaps.

[jardon]

im working on getting the content/sdk snaps rebuilt. the process can take 3-7 hours to build depending on the hardware so the process is pretty slow.

my approach now is to build all the snaps on core22 and relying on glibc and QT compatibility. this reduces the maintenance overhead and should theoretically work. once im done rebuilding the sdk snap, ill work towards testing this out.