-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TLS integration to the NMS #380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
ghislainbourgeois
requested changes
Nov 14, 2024
patriciareinoso
force-pushed
the
TELCO-1408-add-tls-integration-nms
branch
from
November 15, 2024 13:59
d0343ee
to
a9ecc6b
Compare
ghislainbourgeois
approved these changes
Nov 15, 2024
patriciareinoso
force-pushed
the
TELCO-1408-add-tls-integration-nms
branch
from
November 18, 2024 09:03
ecfe5b2
to
1537fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the TLS Certificates Integration to the NMS charm.
This integration is mandatory and the charm does not start the workload without it.
If the integration does not exist or it is removed the charm goes to blocked status.
Certificates and private key are stored at
/support/TLS
incerts
mount.The path to the certificate and private key are added to the webui config file.
The path to the CA certificate is needed to make requests to the webui from the charm.
Attention
Once traefik implements
certificate transfer
interface we'll be able to use that instead of integrating Traefik with self-signed-certificates. canonical/traefik-k8s-operator#407Checklist: