Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TLS integration to the NMS #380

Merged
merged 14 commits into from
Nov 18, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Nov 7, 2024

Description

This PR adds the TLS Certificates Integration to the NMS charm.
This integration is mandatory and the charm does not start the workload without it.
If the integration does not exist or it is removed the charm goes to blocked status.

Certificates and private key are stored at /support/TLS in certs mount.
The path to the certificate and private key are added to the webui config file.

The path to the CA certificate is needed to make requests to the webui from the charm.

Attention

Once traefik implements certificate transfer interface we'll be able to use that instead of integrating Traefik with self-signed-certificates. canonical/traefik-k8s-operator#407

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso patriciareinoso marked this pull request as ready for review November 14, 2024 12:23
@patriciareinoso patriciareinoso requested a review from a team as a code owner November 14, 2024 12:23
src/charm.py Outdated Show resolved Hide resolved
src/nms.py Outdated Show resolved Hide resolved
src/tls.py Show resolved Hide resolved
@patriciareinoso patriciareinoso force-pushed the TELCO-1408-add-tls-integration-nms branch from d0343ee to a9ecc6b Compare November 15, 2024 13:59
@patriciareinoso patriciareinoso force-pushed the TELCO-1408-add-tls-integration-nms branch from ecfe5b2 to 1537fe8 Compare November 18, 2024 09:03
@patriciareinoso patriciareinoso enabled auto-merge (squash) November 18, 2024 09:08
@patriciareinoso patriciareinoso merged commit ceccfab into main Nov 18, 2024
22 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1408-add-tls-integration-nms branch November 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants