Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use v2 of traefik ingress library #30

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: Use v2 of traefik ingress library #30

merged 1 commit into from
Dec 6, 2023

Conversation

patriciareinoso
Copy link
Contributor

Description

The NMS operator has an integration with Traefik which is done over the v1 version of the ingress library. This library is now deprecated. The goal of this PR is to use v2 instead in the NMS operator.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso
Copy link
Contributor Author

waiting for #31 to fix integration tests

@patriciareinoso patriciareinoso marked this pull request as ready for review December 5, 2023 09:52
@patriciareinoso patriciareinoso requested a review from a team as a code owner December 5, 2023 09:52
gruyaume
gruyaume approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@patriciareinoso patriciareinoso force-pushed the TELCO-917-use-v2-traefik branch from 40e02ce to 2d16676 Compare December 6, 2023 08:12
@patriciareinoso
Use v2 of traefik librar
5494d59 
Signed-off-by: Patricia Reinoso <[email protected]>
@patriciareinoso patriciareinoso force-pushed the TELCO-917-use-v2-traefik branch from 2d16676 to 5494d59 Compare December 6, 2023 08:23
@patriciareinoso patriciareinoso merged commit ac5e00e into main Dec 6, 2023
15 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-917-use-v2-traefik branch December 6, 2023 08:46
patriciareinoso pushed a commit that referenced this pull request Dec 6, 2023
@renovate
Update dependency sass to v1.64.0 (#30)
239af70 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patriciareinoso @gruyaume @gatici